feat(sbb-sticky-bar): fade in vertically during initial load [WIP] #3073
+177
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
MarioCastigliano
approved these changes
Sep 11, 2024
Comment on lines
+72
to
+74
| // To decide whether the fade in should happen from bottom up, | ||
| // we check how far away the sticky bar from the intersector is. When scrolling fast, the | ||
| // difference can slightly vary. From this perspective we add a height tolerance. |
There was a problem hiding this comment.
Suggested change
| // To decide whether the fade in should happen from bottom up, | |
| // we check how far away the sticky bar from the intersector is. When scrolling fast, the | |
| // difference can slightly vary. From this perspective we add a height tolerance. | |
| // To decide whether to fade in from the bottom up, | |
| // we check how far away the sticky bar is from the intersector. When scrolling fast, the | |
| // difference can vary slightly. To account for this, we add a height tolerance. |
| this.toggleAttribute( | ||
| 'data-sticking', | ||
| !entry.isIntersecting && entry.boundingClientRect.top > 0, | ||
| 'data-fade-vertically', |
There was a problem hiding this comment.
I'm not 100% sold on the name 'data-fade-vertically' since the animation looks a bit more like a slide-up, but I don't really know a better name and it's a trivial aspect after all 😅
github-actions
bot
added
pr: peer review approved
3 tasks
jeripeierSBB
force-pushed
the
feat-sticky-bar
branch
from
4d4d0a7
to
22ec235
Compare
jeripeierSBB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3072