feat(sbb-header): introduce size s #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jeripeierSBB
reviewed
Sep 2, 2024
mcilurzo
added
the
pr: ux review required
# Conflicts: # src/elements/header/header/header.stories.ts
@mcilurzo 16px 20px from medium |
jeripeierSBB
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM, in case #3080 is merged first, in visual tests we could use stateElement for focus tests instead of custom tabkey solution
mcilurzo
added
pr: ux review approved
|
LGTM. Thank you! |
github-actions
bot
added
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft - to display the logo without text a new property has been added to the
sbb-logocomponent.If the API change is fine, the final visual result should be validated by @mcilurzo, otherwise a different solution (new SVG? new component?) should be find.
EDIT:
signetOnlyis the property proposed name)