Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(step-list): fix border radius of step list elements #3036

Merged
merged 4 commits into from
Aug 29, 2024
Merged

fix(step-list): fix border radius of step list elements #3036

merged 4 commits into from
Aug 29, 2024

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Aug 28, 2024 •
edited
Loading

Closes #3037

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Aug 28, 2024
@jeripeierSBB jeripeierSBB added pr: ux review required A ux review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Aug 28, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Aug 28, 2024
TomMenga
TomMenga approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Aug 28, 2024
@github-actions github-actions bot temporarily deployed to pr3036 August 28, 2024 07:30 Inactive
@github-actions github-actions bot temporarily deployed to pr3036-diff August 28, 2024 07:31 Inactive
@mcilurzo
Copy link
Contributor

LGTM. Thanks

@mcilurzo mcilurzo added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Aug 28, 2024
@github-actions github-actions bot temporarily deployed to pr3036 August 28, 2024 11:11 Inactive
@github-actions github-actions bot temporarily deployed to pr3036-diff August 28, 2024 11:12 Inactive
@jeripeierSBB jeripeierSBB merged commit cf26d07 into main Aug 29, 2024
15 of 16 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-step-list branch August 29, 2024 07:51
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees
No one assigned
Labels
diff-available pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: list (step) -> border radius.
3 participants
@jeripeierSBB @mcilurzo @TomMenga