Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-overlay): fix padding block #3028

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

mcilurzo
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • adjusted "sbb-overlay-padding-block" in all breakpoints. the change is requested by SBB.ch

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Aug 26, 2024
@github-actions github-actions bot temporarily deployed to pr3028 August 26, 2024 15:20 Inactive
@github-actions github-actions bot temporarily deployed to pr3028-diff August 26, 2024 15:21 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for second run of visual regression tests :)

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Aug 27, 2024
@jeripeierSBB jeripeierSBB changed the title fix(overlay): fixed overlay-padding-block fix(sbb-overlay): fix overlay-padding-block Aug 27, 2024
@jeripeierSBB jeripeierSBB changed the title fix(sbb-overlay): fix overlay-padding-block fix(sbb-overlay): fix padding block Aug 27, 2024
@jeripeierSBB jeripeierSBB merged commit 6b95be6 into main Aug 27, 2024
28 of 29 checks passed
@jeripeierSBB jeripeierSBB deleted the fix(overlay)-padding-top branch August 27, 2024 11:47
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Aug 27, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants