Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-slider): add visual tests #2896

Merged
merged 4 commits into from
Jul 8, 2024
Merged

test(sbb-slider): add visual tests #2896

merged 4 commits into from
Jul 8, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 5, 2024
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jul 5, 2024
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2896 July 5, 2024 09:24 Inactive
@github-actions github-actions bot temporarily deployed to pr2896 July 5, 2024 12:09 Inactive
jeripeierSBB
jeripeierSBB reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good, what about the active state?

src/elements/slider/slider.visual.spec.ts Outdated Show resolved Hide resolved
jeripeierSBB
jeripeierSBB approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 8, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit c2adeb2 into main Jul 8, 2024
27 of 28 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-slider branch July 8, 2024 10:49
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@TomMenga TomMenga Awaiting requested review from TomMenga

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavideMininni-Fincons @jeripeierSBB @MarioCastigliano