Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-title): implement visual regression tests #2869

Merged
merged 3 commits into from
Jul 2, 2024
Merged

test(sbb-title): implement visual regression tests #2869

merged 3 commits into from
Jul 2, 2024

Conversation

MarioCastigliano
Copy link
Contributor

not sure if it's worth testing all viewport sizes

@MarioCastigliano MarioCastigliano self-assigned this Jul 1, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 1, 2024
@MarioCastigliano MarioCastigliano mentioned this pull request Jul 1, 2024
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2869 July 1, 2024 15:51 Inactive
TomMenga
TomMenga previously requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)
Some minor fixes

src/elements/title/title.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/title/title.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/title/title.visual.spec.ts Outdated Show resolved Hide resolved
jeripeierSBB
jeripeierSBB reviewed Jul 2, 2024
View reviewed changes
src/elements/title/title.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/title/title.visual.spec.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2869 July 2, 2024 08:26 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one possible refactor

src/elements/title/title.visual.spec.ts Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jul 2, 2024
jeripeierSBB
jeripeierSBB requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adapt also the snapshot.spec.ts file

jeripeierSBB
jeripeierSBB approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@MarioCastigliano MarioCastigliano merged commit 2a33bd9 into main Jul 2, 2024
25 of 26 checks passed
@MarioCastigliano MarioCastigliano deleted the visual-spec/title branch July 2, 2024 13:20
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@TomMenga TomMenga TomMenga left review comments

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@DavideMininni-Fincons DavideMininni-Fincons Awaiting requested review from DavideMininni-Fincons

Assignees

@MarioCastigliano MarioCastigliano

Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarioCastigliano @TomMenga @jeripeierSBB