-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(sbb-menu): add visual tests #2852
Conversation
# Conflicts: # src/elements/core/testing/private/fixture.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG
Some minor fixes and topics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also discuss the viewport stuff?
# Conflicts: # src/elements/core/testing/private/fixture.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
NOTE FOR REVIEWERS
there's an issue in the menu.visual.spec.ts:
viewportHeight: 400
in the describeEach seems to be required to correctly display the component in zero-breakpoint;await setViewport({ width: SbbBreakpointMediumMin, height: 400 });
is needed to correctly display the menu in medium-breakpoint, otherwise its position seems to be at top-left of the page.