test(sbb-menu): add visual tests #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideMininni-Fincons
requested review from
TomMenga,
MarioCastigliano and
dauriamarco
DavideMininni-Fincons
requested review from
kyubisation and
jeripeierSBB
as code owners
github-actions
bot
added
the
pr: peer review required
# Conflicts: # src/elements/core/testing/private/fixture.ts
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
71 tasks
TomMenga
requested changes
Jun 28, 2024
jeripeierSBB
reviewed
Jul 2, 2024
# Conflicts: # src/elements/core/testing/private/fixture.ts
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
added
pr: peer review approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE FOR REVIEWERS
there's an issue in the menu.visual.spec.ts:
viewportHeight: 400in the describeEach seems to be required to correctly display the component in zero-breakpoint;await setViewport({ width: SbbBreakpointMediumMin, height: 400 });is needed to correctly display the menu in medium-breakpoint, otherwise its position seems to be at top-left of the page.