Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: preload icons for testing #2840

Merged
merged 2 commits into from
Jun 26, 2024
Merged

build: preload icons for testing #2840

merged 2 commits into from
Jun 26, 2024

Conversation

kyubisation
Copy link
Contributor

This PR preloads and caches the icons from the CDN, by downloading them once on test run start and injecting them into the test html template.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 26, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

src/elements/icon/icon.ssr.spec.ts Show resolved Hide resolved
tools/web-test-runner/preload-icons.ts Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 26, 2024
@github-actions github-actions bot temporarily deployed to pr2840 June 26, 2024 12:13 Inactive
@kyubisation kyubisation merged commit d3511cc into main Jun 26, 2024
19 of 22 checks passed
@kyubisation kyubisation deleted the build-preload-icons branch June 26, 2024 15:28
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants