Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-clock): treat a specific date consistently #2838

Merged
merged 8 commits into from
Jun 27, 2024
Merged

fix(sbb-clock): treat a specific date consistently #2838

merged 8 commits into from
Jun 27, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Jun 26, 2024 •
edited
Loading

It is a long shot, but could cause the issue we have

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 26, 2024
@TomMenga TomMenga changed the title test(sbb-clock): stabilize visual spec test(sbb-clock): stabilize visual spec Jun 26, 2024
@github-actions github-actions bot temporarily deployed to pr2838 June 26, 2024 09:52 Inactive
@github-actions github-actions bot temporarily deployed to pr2838 June 26, 2024 11:26 Inactive
@github-actions github-actions bot temporarily deployed to pr2838 June 26, 2024 11:39 Inactive
TomMenga
TomMenga commented Jun 26, 2024
View reviewed changes
Copy link
Contributor Author

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the readability improved. I just have a couple of suggestions to improve it further.
Also, I did some manual testing and it seems to work just fine 😄

src/elements/clock/clock.ts Show resolved Hide resolved
src/elements/clock/clock.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2838 June 26, 2024 14:23 Inactive
@jeripeierSBB jeripeierSBB changed the title test(sbb-clock): stabilize visual spec fix(sbb-clock): treat a specific date consistently Jun 27, 2024
jeripeierSBB
jeripeierSBB approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 27, 2024
@TomMenga TomMenga merged commit 4ffa4bc into main Jun 27, 2024
30 of 31 checks passed
@TomMenga TomMenga deleted the visual-spec/stabilize-clock branch June 27, 2024 07:06
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 27, 2024
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideMininni-Fincons DavideMininni-Fincons DavideMininni-Fincons left review comments

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomMenga @jeripeierSBB @DavideMininni-Fincons