Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-form-field): add visual spec #2807

Merged
merged 11 commits into from
Jun 27, 2024
Merged

test(sbb-form-field): add visual spec #2807

merged 11 commits into from
Jun 27, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

To discuss: reduce test cases?

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 21, 2024
@DavideMininni-Fincons DavideMininni-Fincons changed the title test(sbb-form-field): add visual spec test(sbb-form-field): add visual spec [WIP] Jun 21, 2024
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 21, 2024
@github-actions github-actions bot temporarily deployed to pr2807 June 21, 2024 15:40 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title test(sbb-form-field): add visual spec [WIP] test(sbb-form-field): add visual spec Jun 24, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 24, 2024
@github-actions github-actions bot temporarily deployed to pr2807 June 24, 2024 07:53 Inactive
@github-actions github-actions bot temporarily deployed to pr2807 June 24, 2024 10:41 Inactive
@github-actions github-actions bot temporarily deployed to pr2807 June 24, 2024 13:45 Inactive
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jun 25, 2024
Closed
71 tasks
jeripeierSBB
jeripeierSBB requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Basically I think it's ok if there are a lot of combinations. It's in the nature of the form field that there are a lot of possible combinations and visual outcomes.

src/elements/form-field/form-field-clear/form-field-clear.snapshot.spec.ts Outdated Show resolved Hide resolved
src/elements/form-error/form-error.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/form-error/form-error.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/form-field/form-field-clear/form-field-clear.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/form-field/form-field/form-field.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/form-field/form-field/form-field.visual.spec.ts Outdated Show resolved Hide resolved
src/elements/form-field/form-field/form-field.visual.spec.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2807 June 26, 2024 09:14 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure whether the active and focus state should also be tested with negative? I tend to a yes

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 27, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 8e9c543 into main Jun 27, 2024
20 of 22 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-form-field branch June 27, 2024 10:41
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@TomMenga TomMenga Awaiting requested review from TomMenga

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideMininni-Fincons @jeripeierSBB