fix: verify SSR functionality #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
github-actions
bot
removed
the
pr: peer review required
kyubisation
force-pushed
the
fix-ssr
branch
2 times, most recently
from
f4463a4
to
ae4ebc7
Compare
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
github-actions
bot
added
the
pr: peer review required
TomMenga
added
pr: peer review approved
Closes #2793 This PR addresses a problem in our SSR testing, which falsified the test results. Due to this, we were able to fix issues in `sbb-option` and list components. Additionally it disables SSR for the `sbb-calendar` component, as it requires a significant refactoring to fully work with SSR.
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2793
This PR addresses a problem in our SSR testing, which falsified the test results. Due to this, we were able to fix issues in
sbb-optionand list components. Additionally it disables SSR for thesbb-calendarcomponent, as it requires a significant refactoring to fully work with SSR.