Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verify SSR functionality #2805

Merged
merged 4 commits into from
Jun 24, 2024
Merged

fix: verify SSR functionality #2805

merged 4 commits into from
Jun 24, 2024

Conversation

kyubisation
Copy link
Contributor

Closes #2793

This PR addresses a problem in our SSR testing, which falsified the test results. Due to this, we were able to fix issues in sbb-option and list components. Additionally it disables SSR for the sbb-calendar component, as it requires a significant refactoring to fully work with SSR.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 21, 2024
@kyubisation kyubisation marked this pull request as draft June 21, 2024 14:44
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 21, 2024
@kyubisation kyubisation force-pushed the fix-ssr branch 2 times, most recently from f4463a4 to ae4ebc7 Compare June 21, 2024 15:50
@github-actions github-actions bot temporarily deployed to pr2805 June 24, 2024 11:42 Inactive
@kyubisation kyubisation marked this pull request as ready for review June 24, 2024 11:47
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 24, 2024
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄👍

@TomMenga TomMenga added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jun 24, 2024
Closes #2793

This PR addresses a problem in our SSR testing, which falsified
the test results. Due to this, we were able to fix issues in `sbb-option`
and list components. Additionally it disables SSR for the `sbb-calendar`
component, as it requires a significant refactoring to fully work with SSR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SSR issue with sbb-autocomplete
2 participants