Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(table): add 'color-iron' variant #2803

Merged
merged 3 commits into from
Jun 24, 2024
Merged

style(table): add 'color-iron' variant #2803

merged 3 commits into from
Jun 24, 2024

Conversation

TomMenga
Copy link
Contributor

No description provided.

@TomMenga TomMenga added the pr: ux review required A ux review is required for this pull request label Jun 21, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 21, 2024
@github-actions github-actions bot temporarily deployed to pr2803 June 21, 2024 07:49 Inactive
@TomMenga TomMenga added the pr: lead review required A lead review is required for this pull request label Jun 21, 2024
@github-actions github-actions bot added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Jun 21, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
One open question about naming, but I would be fine with the current name.

src/elements/core/styles/table.scss Outdated Show resolved Hide resolved
@github-actions github-actions bot added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Jun 21, 2024
@TomMenga TomMenga merged commit 4e0e1f8 into main Jun 24, 2024
24 of 26 checks passed
@TomMenga TomMenga deleted the fix/table branch June 24, 2024 08:44
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants