Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sbb-calendar): add visual tests #2789

Merged
merged 7 commits into from
Jun 20, 2024
Merged

test(sbb-calendar): add visual tests #2789

merged 7 commits into from
Jun 20, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Jun 17, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot temporarily deployed to pr2789 June 17, 2024 15:38 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title test(sbb-calendar): add visual tests [WIP] test(sbb-calendar): add visual tests Jun 18, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 18, 2024
@DavideMininni-Fincons DavideMininni-Fincons linked an issue Jun 18, 2024 that may be closed by this pull request
Refactoring: Migration of visual regression tests and testfile restructering #2731
Closed
71 tasks
@DavideMininni-Fincons DavideMininni-Fincons removed a link to an issue Jun 18, 2024
Refactoring: Migration of visual regression tests and testfile restructering #2731
Closed
71 tasks
@github-actions github-actions bot temporarily deployed to pr2789 June 18, 2024 10:05 Inactive
TomMenga
TomMenga requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case test names are a bit unfortunate, not sure we can do something about it :/

image

src/elements/calendar/calendar.snapshot.spec.ts Outdated Show resolved Hide resolved
@DavideMininni-Fincons
Copy link
Contributor Author

The case test names are a bit unfortunate, not sure we can do something about it :/

image

I did a fix for it but i'm not sure it can matches all the possible cases

@github-actions github-actions bot temporarily deployed to pr2789 June 19, 2024 07:37 Inactive
TomMenga
TomMenga approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jun 19, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 2d9b8b8 into main Jun 20, 2024
24 of 26 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the test/migration-calendar branch June 20, 2024 09:03
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Jun 25, 2024
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

Assignees
No one assigned
Labels
diff-available pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideMininni-Fincons @TomMenga