-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-container): first implementation #2271
Conversation
e35d9a0
to
fa18453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I added some comments ;)
7610328
to
8e97125
Compare
da2c65b
to
b82937b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
=======================================
Coverage ? 93.65%
=======================================
Files ? 225
Lines ? 23391
Branches ? 2059
=======================================
Hits ? 21906
Misses ? 1446
Partials ? 39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. 👍
Some small changes and some topic to discuss
Ps. Don't forget to approve the new stories on chromatic when you get the ok from the UX
9ba4ff3
to
e104bba
Compare
e104bba
to
20d2b6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementing these components! There are some things to address and also topics to discuss probably.
- I think we should use the sbb-container in our stories where possible, so at least in the home stories (instead of the grid, at least when container supports grid :) ).
- In page layout docs (src/storybook/styles/layout/readme.md) we should probably mention the new possibility of the sbb-container.
6273faa
to
73ebf69
Compare
0566c5d
to
e85525e
Compare
04546f8
to
14e9d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new approach! There are some topics which needed to be addressed.
ce97d11
to
774402c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preflight Checklist
Issue
This PR Closes #1908
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information