Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-container): first implementation #2271

Merged
merged 63 commits into from
Feb 8, 2024
Merged

Conversation

MarioCastigliano
Copy link
Contributor

@MarioCastigliano MarioCastigliano commented Dec 7, 2023

Preflight Checklist

Issue

This PR Closes #1908

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@MarioCastigliano MarioCastigliano changed the title Feat/sbb container feat(sbb-container): first implementation Dec 7, 2023
@MarioCastigliano MarioCastigliano force-pushed the feat/sbb-container branch 2 times, most recently from e35d9a0 to fa18453 Compare December 7, 2023 15:46
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I added some comments ;)

src/components/container/container/container.spec.ts Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/readme.md Outdated Show resolved Hide resolved
src/components/container/sticky-bar/readme.md Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.stories.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.stories.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.stories.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@bfb27d1). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2271   +/-   ##
=======================================
  Coverage        ?   93.65%           
=======================================
  Files           ?      225           
  Lines           ?    23391           
  Branches        ?     2059           
=======================================
  Hits            ?    21906           
  Misses          ?     1446           
  Partials        ?       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. 👍
Some small changes and some topic to discuss

Ps. Don't forget to approve the new stories on chromatic when you get the ok from the UX

src/components/container/container/container.ts Outdated Show resolved Hide resolved
src/components/container/container/container.ts Outdated Show resolved Hide resolved
src/components/container/container/container.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.scss Outdated Show resolved Hide resolved
src/components/container/container/container.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementing these components! There are some things to address and also topics to discuss probably.

  • I think we should use the sbb-container in our stories where possible, so at least in the home stories (instead of the grid, at least when container supports grid :) ).
  • In page layout docs (src/storybook/styles/layout/readme.md) we should probably mention the new possibility of the sbb-container.

src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.scss Outdated Show resolved Hide resolved
src/components/container/container/container.scss Outdated Show resolved Hide resolved
src/components/container/container/container.scss Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.scss Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new approach! There are some topics which needed to be addressed.

src/components/container/sticky-bar/sticky-bar.scss Outdated Show resolved Hide resolved
src/components/container/container/readme.md Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.stories.ts Outdated Show resolved Hide resolved
src/components/container/container/container.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.stories.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.ts Outdated Show resolved Hide resolved
src/components/container/sticky-bar/sticky-bar.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a deployment to preview-pr2271 January 15, 2024 08:21 In progress
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeripeierSBB jeripeierSBB added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Feb 8, 2024
@MarioCastigliano MarioCastigliano merged commit 7403b67 into main Feb 8, 2024
15 checks passed
@MarioCastigliano MarioCastigliano deleted the feat/sbb-container branch February 8, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: ux review approved Pull request has been approved by a ux review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story(sbb-container, sbb-sticky-bar): initial implementation
7 participants