Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sbb-breadcrumb): support SSR and hydration #2224

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (cbc7afd) 95.94%.
Report is 71 commits behind head on master.

Files Patch % Lines
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 70.00% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 25.00% 3 Missing ⚠️
src/components/calendar/calendar.ts 86.66% 2 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
... and 26 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2224      +/-   ##
==========================================
+ Coverage   92.61%   95.94%   +3.33%     
==========================================
  Files          53      329     +276     
  Lines        2409    39072   +36663     
  Branches      254     2169    +1915     
==========================================
+ Hits         2231    37487   +35256     
- Misses        176     1541    +1365     
- Partials        2       44      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2224 November 23, 2023 14:39 In progress
@jeripeierSBB jeripeierSBB merged commit e38ee8a into master Nov 23, 2023
15 checks passed
@jeripeierSBB jeripeierSBB deleted the fix-breadcrumnb branch November 23, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants