Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-slider): fix trapped focus on the knob #2222

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix(sbb-slider): fix trapped focus on the knob #2222

merged 1 commit into from
Nov 23, 2023

Conversation

dauriamarco
Copy link
Contributor

No description provided.

@dauriamarco dauriamarco self-assigned this Nov 23, 2023
@jeripeierSBB jeripeierSBB changed the title fix(sbb-slider): focus gets stuck on the knob fix(sbb-slider): fix trapped focus on the knob Nov 23, 2023
jeripeierSBB
jeripeierSBB approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a deployment to preview-pr2222 November 23, 2023 13:04 In progress
@dauriamarco dauriamarco merged commit cbe33ad into master Nov 23, 2023
17 checks passed
@dauriamarco dauriamarco deleted the fix/slider-focus branch November 23, 2023 13:11
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation

Assignees

@dauriamarco dauriamarco

Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dauriamarco @jeripeierSBB