Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused import and code #2221

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

Removed unused method on sbb-datepicker-toggle and imports in sbb-logo and sbb-signet.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (278d88d) 96.03%.
Report is 67 commits behind head on master.

❗ Current head 278d88d differs from pull request most recent head dac05d0. Consider uploading reports for the commit dac05d0 to get more accurate results

Files Patch % Lines
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 25.00% 3 Missing ⚠️
src/components/calendar/calendar.ts 75.00% 2 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
src/components/menu/menu/menu.ts 75.00% 2 Missing ⚠️
... and 25 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2221      +/-   ##
==========================================
+ Coverage   92.61%   96.03%   +3.42%     
==========================================
  Files          53      329     +276     
  Lines        2409    39079   +36670     
  Branches      254     2178    +1924     
==========================================
+ Hits         2231    37529   +35298     
- Misses        176     1504    +1328     
- Partials        2       46      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, investigate why eslint doesn't find it

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot requested a deployment to preview-pr2221 November 23, 2023 13:56 In progress
@DavideMininni-Fincons DavideMininni-Fincons merged commit 0555549 into master Nov 23, 2023
13 of 15 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the fix/code-cleaning branch November 23, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants