Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update coding standards #2219

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

dauriamarco
Copy link
Contributor

Closes #2210

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (e09f468) 95.97%.
Report is 74 commits behind head on master.

Files Patch % Lines
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 25.00% 3 Missing ⚠️
src/components/calendar/calendar.ts 75.00% 2 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
src/components/menu/menu/menu.ts 75.00% 2 Missing ⚠️
... and 25 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
+ Coverage   92.61%   95.97%   +3.36%     
==========================================
  Files          53      329     +276     
  Lines        2409    39096   +36687     
  Branches      254     2183    +1929     
==========================================
+ Hits         2231    37522   +35291     
- Misses        176     1528    +1352     
- Partials        2       46      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

CODING_STANDARDS.md Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a deployment to preview-pr2219 November 23, 2023 15:18 In progress
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dauriamarco dauriamarco merged commit c832459 into master Nov 23, 2023
15 checks passed
@dauriamarco dauriamarco deleted the refactor/coding-standards branch November 23, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update coding standards to lit
4 participants