Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: minify CSS in build bundle #2216

Merged
merged 1 commit into from
Nov 22, 2023
Merged

build: minify CSS in build bundle #2216

merged 1 commit into from
Nov 22, 2023

Conversation

kyubisation
Copy link
Contributor

This PR configures Vite to minify CSS in our build bundle. This should reduce the payload both for our package and our consumers.

@codecov-commenter
Copy link

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (6f09596) 95.98%.
Report is 54 commits behind head on master.

Files Patch % Lines
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 25.00% 3 Missing ⚠️
src/components/calendar/calendar.ts 75.00% 2 Missing ⚠️
src/components/core/dom/find-referenced-element.ts 60.00% 2 Missing ⚠️
src/components/menu/menu/menu.ts 0.00% 2 Missing ⚠️
.../navigation/navigation-marker/navigation-marker.ts 50.00% 2 Missing ⚠️
... and 25 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2216      +/-   ##
==========================================
+ Coverage   92.61%   95.98%   +3.37%     
==========================================
  Files          53      326     +273     
  Lines        2409    38960   +36551     
  Branches      254     2191    +1937     
==========================================
+ Hits         2231    37396   +35165     
- Misses        176     1519    +1343     
- Partials        2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyubisation kyubisation merged commit 656550d into master Nov 22, 2023
14 of 16 checks passed
@kyubisation kyubisation deleted the build-css-minify branch November 22, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants