Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename event names to camelCase #2215

Merged
merged 17 commits into from
Nov 27, 2023
Merged

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Nov 21, 2023

BREAKING CHANGE:

  • sbb-alert: Event will-present was renamed to willPresent.
  • sbb-alert: Event did-present was renamed to didPresent.
  • sbb-alert: Event dismissal-requested was renamed to dismissalRequested.
  • sbb-alert-group: Event did-dismiss-alert was renamed to didDismissAlert.
  • sbb-autocomplete: Event will-open was renamed to willOpen.
  • sbb-autocomplete: Event did-open was renamed to didOpen.
  • sbb-autocomplete: Event will-close was renamed to willClose.
  • sbb-autocomplete: Event did-close was renamed to didClose.
  • sbb-calendar: Event date-selected was renamed to dateSelected.
  • sbb-checkbox: Event did-change was renamed to didChange.
  • sbb-dialog: Event will-open was renamed to willOpen.
  • sbb-dialog: Event did-open was renamed to didOpen.
  • sbb-dialog: Event will-close was renamed to willClose.
  • sbb-dialog: Event did-close was renamed to didClose.
  • sbb-dialog: Event request-back-action was renamed to requestBackAction.
  • sbb-expansion-panel: Event will-open was renamed to willOpen.
  • sbb-expansion-panel: Event did-open was renamed to didOpen.
  • sbb-expansion-panel: Event will-close was renamed to willClose.
  • sbb-expansion-panel: Event did-close was renamed to didClose.
  • sbb-expansion-panel-header: Event toggle-expanded was renamed to toggleExpanded.
  • sbb-file-selector: Event file-changed was renamed to fileChanged.
  • sbb-menu: Event will-open was renamed to willOpen.
  • sbb-menu: Event did-open was renamed to didOpen.
  • sbb-menu: Event will-close was renamed to willClose.
  • sbb-menu: Event did-close was renamed to didClose.
  • sbb-notification: Event will-open was renamed to willOpen.
  • sbb-notification: Event did-open was renamed to didOpen.
  • sbb-notification: Event will-close was renamed to willClose.
  • sbb-notification: Event did-close was renamed to didClose.
  • sbb-option: Event option-selection-change was renamed to optionSelectionChange.
  • sbb-option: Event option-selected was renamed to optionSelected.
  • sbb-select: Event will-open was renamed to willOpen.
  • sbb-select: Event did-open was renamed to didOpen.
  • sbb-select: Event will-close was renamed to willClose.
  • sbb-select: Event did-close was renamed to didClose.
  • sbb-tab-group: Event did-change was renamed to didChange.
  • sbb-tag: Event state-change was renamed to stateChange and was changed to an internal event.
  • sbb-toast: Event will-open was renamed to willOpen.
  • sbb-toast: Event did-open was renamed to didOpen.
  • sbb-toast: Event will-close was renamed to willClose.
  • sbb-toast: Event did-close was renamed to didClose.
  • sbb-tooltip: Event will-open was renamed to willOpen.
  • sbb-tooltip: Event did-open was renamed to didOpen.
  • sbb-tooltip: Event will-close was renamed to willClose.
  • sbb-tooltip: Event did-close was renamed to didClose.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (638977d) 92.61% compared to head (c1b2d82) 95.98%.
Report is 80 commits behind head on master.

Files Patch % Lines
src/components/core/dom/spread.ts 80.48% 8 Missing ⚠️
...nents/core/common-behaviors/slot-child-observer.ts 93.33% 5 Missing ⚠️
src/components/core/dom/breakpoint.ts 42.85% 4 Missing ⚠️
src/components/autocomplete/autocomplete.ts 85.71% 3 Missing ⚠️
src/components/card/card-action/card-action.ts 70.00% 3 Missing ⚠️
src/components/core/dom/dataset.ts 25.00% 3 Missing ⚠️
src/components/core/dom/host-context.ts 40.00% 3 Missing ⚠️
src/components/header/header/header.ts 50.00% 3 Missing ⚠️
src/components/image/image.ts 93.33% 3 Missing ⚠️
src/components/tooltip/tooltip/tooltip.ts 75.00% 3 Missing ⚠️
... and 28 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
+ Coverage   92.61%   95.98%   +3.36%     
==========================================
  Files          53      330     +277     
  Lines        2409    39155   +36746     
  Branches      254     2187    +1933     
==========================================
+ Hits         2231    37581   +35350     
- Misses        176     1529    +1353     
- Partials        2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot requested a deployment to preview-pr2215 November 23, 2023 11:43 In progress
@github-actions github-actions bot requested a deployment to preview-pr2215 November 23, 2023 12:11 In progress
@github-actions github-actions bot requested a deployment to preview-pr2215 November 23, 2023 16:05 In progress
@github-actions github-actions bot requested a deployment to preview-pr2215 November 27, 2023 08:51 In progress
@github-actions github-actions bot requested a deployment to preview-pr2215 November 27, 2023 09:24 In progress
@jeripeierSBB jeripeierSBB merged commit 9b657e8 into master Nov 27, 2023
13 of 15 checks passed
@jeripeierSBB jeripeierSBB deleted the event-name-alignment branch November 27, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants