fix(sbb-button, sbb-link): rename static attribute to is-static
#1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - In order to fully support typings, `static` property of `sbb-link` and `sbb-button` have been renamed to `is-static`.
jeripeierSBB
requested review from
kyubisation,
DavideMininni-Fincons,
dauriamarco,
federicoisepponfincons,
MarioCastigliano and
TomMenga
as code owners
jeripeierSBB
changed the title
static property to is-staticstatic attribute to is-static
DavideMininni-Fincons
approved these changes
Jun 29, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1850 +/- ##
===========================================
- Coverage 54.85% 37.44% -17.41%
===========================================
Files 49 257 +208
Lines 1659 9830 +8171
Branches 406 2119 +1713
===========================================
+ Hits 910 3681 +2771
- Misses 671 5882 +5211
- Partials 78 267 +189
... and 201 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
staticattribute ofsbb-linkandsbb-buttonhave been renamed tois-static(propertyisStatic).