Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-toggle-check): add new size variant (M) #1849

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

dauriamarco
Copy link
Contributor

Closes #1846

@github-actions github-actions bot temporarily deployed to preview-pr1849 June 29, 2023 10:45 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #1849 (78ee391) into master (ab917b0) will decrease coverage by 17.42%.
The diff coverage is 34.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #1849       +/-   ##
===========================================
- Coverage   54.85%   37.44%   -17.42%     
===========================================
  Files          49      257      +208     
  Lines        1659     9834     +8175     
  Branches      406     2119     +1713     
===========================================
+ Hits          910     3682     +2772     
- Misses        671     5885     +5214     
- Partials       78      267      +189     
Impacted Files Coverage Δ
...ts/sbb-accordion-item/sbb-accordion-item.events.ts 100.00% <ø> (ø)
.../sbb-accordion-item/sbb-accordion-item.stories.tsx 0.00% <0.00%> (ø)
...mponents/sbb-accordion-item/sbb-accordion-item.tsx 0.00% <0.00%> (-37.21%) ⬇️
...components/sbb-accordion/sbb-accordion.stories.tsx 0.00% <0.00%> (ø)
...ents/sbb-action-group/sbb-action-group.stories.tsx 0.00% <0.00%> (ø)
...onents/sbb-alert-group/sbb-alert-group.stories.tsx 0.00% <0.00%> (ø)
src/components/sbb-alert/sbb-alert.stories.tsx 0.00% <0.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
...ents/sbb-autocomplete/sbb-autocomplete.stories.tsx 0.00% <0.00%> (ø)
src/components/sbb-button/sbb-button.stories.tsx 0.00% <0.00%> (ø)
... and 58 more

... and 201 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Let's have @mcilurzo also take a look at it.

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dauriamarco dauriamarco merged commit 6c20d1f into master Jun 29, 2023
12 checks passed
@dauriamarco dauriamarco deleted the feat/toggle-check-size-m branch June 29, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: new size (M) for toggle-check component
4 participants