-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbb-select): select shows selected value in form field instead of the label #1843
fix(sbb-select): select shows selected value in form field instead of the label #1843
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1843 +/- ##
===========================================
- Coverage 54.85% 37.50% -17.35%
===========================================
Files 49 257 +208
Lines 1659 9807 +8148
Branches 406 2109 +1703
===========================================
+ Hits 910 3678 +2768
- Misses 671 5862 +5191
- Partials 78 267 +189
... and 201 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bascially LGTM 👍
One question about event content.
0930baf
to
44c81bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring, thanks
Preflight Checklist
Issue
This PR Closes #1827
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
@Watch('selected')
on the sbb-option has been removed to avoid infinite loops;selectionChange
event is triggered only in user interaction cases;@Watch('value')
on sbb-select now looks on values on the sbb-options to display the correct label;@Method
has been added to fetch the displayValue.Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information