Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-form-field): improve floating label for various input types #1842

Merged
merged 4 commits into from
Jun 28, 2023
Merged

fix(sbb-form-field): improve floating label for various input types #1842

merged 4 commits into from
Jun 28, 2023

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Jun 27, 2023 •
edited
Loading

No description provided.

@jeripeierSBB jeripeierSBB changed the title fix(sbb-form-field): better handle floating label for various input t… fix(sbb-form-field): better handle floating label for various input types Jun 27, 2023
@jeripeierSBB jeripeierSBB marked this pull request as draft June 27, 2023 13:23
@jeripeierSBB jeripeierSBB changed the title fix(sbb-form-field): better handle floating label for various input types fix(sbb-form-field): improve floating label for various input types Jun 28, 2023
@jeripeierSBB jeripeierSBB marked this pull request as ready for review June 28, 2023 14:09
@github-actions github-actions bot temporarily deployed to preview-pr1842 June 28, 2023 14:17 Inactive
DavideMininni-Fincons
DavideMininni-Fincons approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Very very nitpicky: html format in the e2e tests could be improved (first line is ok, then text goes a little too far to the right by a couple of tabs).

kyubisation
kyubisation approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM 👍

src/components/sbb-form-field/sbb-form-field.stories.tsx Outdated Show resolved Hide resolved
src/components/sbb-form-field/sbb-form-field.tsx Outdated Show resolved Hide resolved
@jeripeierSBB jeripeierSBB merged commit a25637f into master Jun 28, 2023
@jeripeierSBB jeripeierSBB deleted the fix-floating-labels branch June 28, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@DavideMininni-Fincons DavideMininni-Fincons DavideMininni-Fincons approved these changes

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

@federicoisepponfincons federicoisepponfincons Awaiting requested review from federicoisepponfincons

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@TomMenga TomMenga Awaiting requested review from TomMenga

Assignees
No one assigned
Labels
preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeripeierSBB @kyubisation @DavideMininni-Fincons