Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reorder stories #1841

Merged
merged 3 commits into from
Jul 3, 2023
Merged

docs: reorder stories #1841

merged 3 commits into from
Jul 3, 2023

Conversation

federicoisepponfincons
Copy link
Contributor

@federicoisepponfincons federicoisepponfincons commented Jun 27, 2023

Preflight Checklist

Issue

This PR Closes #1829

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • reorder of Storybook stories

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot temporarily deployed to preview-pr1841 June 27, 2023 09:58 Inactive
@jeripeierSBB jeripeierSBB changed the title feat: stories reorder docs: reorder stories Jun 27, 2023
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Please change the following:

  • Remove the folder "form elements"
  • Insert sbb-calendar into sbb-datepicker
  • Group sbb-form-error with sbb-form-field
  • Group sbb-option and sbb-optgroup to sbb-option

.storybook/preview.js Show resolved Hide resolved
@jeripeierSBB
Copy link
Contributor

@federicoisepponfincons after rebasing, also breadcrumb should be grouped

@github-actions github-actions bot temporarily deployed to preview-pr1841 July 3, 2023 10:49 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #1841 (58e1856) into master (ab917b0) will decrease coverage by 17.37%.
The diff coverage is 32.98%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #1841       +/-   ##
===========================================
- Coverage   54.85%   37.48%   -17.37%     
===========================================
  Files          49      261      +212     
  Lines        1659    10027     +8368     
  Branches      406     2158     +1752     
===========================================
+ Hits          910     3759     +2849     
- Misses        671     5996     +5325     
- Partials       78      272      +194     
Impacted Files Coverage Δ
...ts/sbb-accordion-item/sbb-accordion-item.events.ts 100.00% <ø> (ø)
.../sbb-accordion-item/sbb-accordion-item.stories.tsx 0.00% <0.00%> (ø)
...mponents/sbb-accordion-item/sbb-accordion-item.tsx 0.00% <0.00%> (-37.21%) ⬇️
...components/sbb-accordion/sbb-accordion.stories.tsx 0.00% <0.00%> (ø)
...ents/sbb-action-group/sbb-action-group.stories.tsx 0.00% <0.00%> (ø)
...onents/sbb-alert-group/sbb-alert-group.stories.tsx 0.00% <0.00%> (ø)
src/components/sbb-alert/sbb-alert.stories.tsx 0.00% <0.00%> (ø)
...onents/sbb-autocomplete/sbb-autocomplete.events.ts 100.00% <ø> (ø)
...ents/sbb-autocomplete/sbb-autocomplete.stories.tsx 0.00% <0.00%> (ø)
...-breadcrumb-group/sbb-breadcrumb-group.stories.tsx 0.00% <0.00%> (ø)
... and 58 more

... and 205 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@federicoisepponfincons federicoisepponfincons merged commit 12a8dc0 into master Jul 3, 2023
@federicoisepponfincons federicoisepponfincons deleted the origin/story-reorder branch July 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story: reorder and tidy up Storybook component list
3 participants