Skip to content

Commit

Permalink
Revert "fix: Allow concurrent validation_test steps"
Browse files Browse the repository at this point in the history
This reverts commit c25c111. This was a minor speedup and we don't need it since we can easily cancel validation test steps if necessary.
  • Loading branch information
Yonathan Randolph committed Aug 18, 2023
1 parent c25c111 commit fb9f50c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pipeline.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ func (p *Pipeline) Lower(context *Context) ([]interface{}, error) {
EnvironmentName: envName,
QueueName: "validation_test",
EmojiName: "curly_loop",
PreventConcurrency: true,
}
loweredSteps, err := lowerSteps(
p.ValidationTest, context, stepContext,
Expand All @@ -156,6 +157,7 @@ func (p *Pipeline) Lower(context *Context) ([]interface{}, error) {
EnvironmentName: envName,
QueueName: "validation_test",
EmojiName: "curly_loop",
PreventConcurrency: true,
}

// Manual deploys run sequentially, so that they can
Expand Down
6 changes: 6 additions & 0 deletions testdata/basic_master.out.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ steps:
environment: dev
queue: validation_test
command: integrationtest
concurrency: 1
concurrency_group: dev/myrepo
concurrency_method: eager
env:
JOBSWORTH_CAUTIOUS: "0"
JOBSWORTH_CODE_VERSION: ""
Expand Down Expand Up @@ -102,6 +105,9 @@ steps:
environment: prod
queue: validation_test
command: integrationtest
concurrency: 1
concurrency_group: prod/myrepo
concurrency_method: eager
env:
JOBSWORTH_CAUTIOUS: "0"
JOBSWORTH_CODE_VERSION: ""
Expand Down

0 comments on commit fb9f50c

Please sign in to comment.