Add query tool for crafting database #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsobolev
reviewed
Jun 27, 2025
| PRAGMA synchronous = NORMAL; | ||
|
|
||
| CREATE TABLE IF NOT EXISTS items ( | ||
| id INTEGER PRIMARY KEY, |
There was a problem hiding this comment.
I'm not experienced in SQL, but as I understand INTEGER means Int32. It doesn't fit, items IDs in BitPlanner scripts are expected to be in range of UInt64 (BIGINT UNSIGNED), by using Int32 you will get overflow on cargo items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
query_crafting_db.pyfor dependency queriesTesting
python3 -m py_compile create_crafting_db.py query_crafting_db.pyhttps://chatgpt.com/codex/tasks/task_e_685eb3b388ac83318c4976ced53993e1