Updated disp_sidebar functionality, it should no longer revert to displaying the sb if options.disp.sidebar=False
#2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziova
commented
Aug 15, 2024
ziova
commented
- If contributing a core loader, the loader checklist was referenced.
- If registering an external plugin, the plugin checklist was referenced.
|
|
ziova
changed the title
disp_sidebar functionality, it should no longer revert to displaying if options.disp.sidebar=Falsedisp_sidebar functionality, it should no longer revert to displaying the sb if options.disp.sidebar=False
|
Hi @ziova, thanks for the suggestion. If we do this, however, you will never see any status messages when the sidebar is disabled. This isn't workable, as status messages often have essential feedback for commands. I have some code I'm working on to handle the sidebar, which I'll hopefully get around to finishing in the next week or so. |
|
Oh @saulpw, thank you this has been noted. I'm looking forward to your updated code :) Closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.