[fec-] fix diving into row sheets #2434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulpw
reviewed
Jun 29, 2024
| @@ -230,7 +210,7 @@ class FECFiling(Sheet): | |||
| @asyncthread | |||
| def reload(self): | |||
| from fecfile import fecparser | |||
| self.rows = [] | |||
| self.rows = [] # rowdef: Sheet, of a type from COMPONENT_SHEET_CLASSES.values() | |||
There was a problem hiding this comment.
In general if the rowdef is a Sheet then the parent class is IndexSheet, which provides default columns and other functionality. I'm not sure if it applies here but it might be worth exploring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2433.
Also takes
open_fec()out of the global namespace. It's a trivial change. I foundopen_fec()in the global namespace when I was looking for stray functions of the formopen_*()andsave_*().