[misc-] fix minor name definition errors caught by pyflakes #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replayCommand() is unused, but fixing it silences linter warnings.
saulpw
reviewed
Jul 1, 2024
saulpw
reviewed
Jul 1, 2024
| @@ -179,10 +179,6 @@ def name(self): | |||
| 'Filename without any extensions. Not the same as pathlib.Path.' | |||
| return self.base_stem | |||
|
|
|||
| @lru_cache() | |||
| def stat(self, force=False): | |||
There was a problem hiding this comment.
Removing this makes me nervous. It should still work, as members that aren't defined explicitly fall back to self._path, but the @lru_cache will make this much faster for DirSheets which would otherwise stat the same file repeatedly. How can pyflakes know this isn't used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran pyflakes, and it uncovered some errors related to symbols that weren't defined, or were defined more than once. These are only minor errors in code that is rarely run, or never run.