New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[save-] handle empty delimiter when safety_first #2421

Merged

anjakefala merged 1 commit into saulpw:develop from midichef:safety_delimiter

Jul 2, 2024

Contributor

midichef commented Jun 10, 2024

With --safety-first, saving a sheet fails when using '\x00' as a delimiter.

echo "col\none\0two" |vd --safety-first --delimiter= -f tsv - then execute save-sheet:

File "/home/midichef/.local/lib/python3.10/site-packages/visidata/save.py", line 18, in safe_trdict
    ord(delim): vs.options.tsv_safe_tab, # \t
TypeError: ord() expected a character, but string of length 0 found

This PR changes the behavior to fail, with an explanatory message, when the delimiter is '\x00', '\r', or '\n'.


          [save-] handle empty delimiter when safety_first

8fea025

saulpw approved these changes

View reviewed changes

Owner

saulpw left a comment

At some point I'd like to rework safety_first, since it's used in only a few places. But this is fine for what it is now.

anjakefala merged commit 2549f14 into saulpw:develop

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment