-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mouse-] click on error note to run error-cell #2381
Conversation
I agree with making the |
Okay, I renamed |
d0be22c
to
1e69453
Compare
Okay, I moved to the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @midichef! We'll deprecate view-cell
and remove the underline from (some) clickables separately.
1e69453
to
fbd06c8
Compare
Thanks @midichef! I also included clickable type exceptions in this PR. =) |
- underlined notes (like type errors) look terrible
This is a UI change, to let users click on the
!
symbol to runerror-cell
. The goal is to make theerror-cell
command easier to discover, and easier to get to without remembering the shortcutzCtrl+E
or the command name.A drawback is that users may accidentally click on the
!
, thinking they're clicking on a cell. Aftererror-cell
runs they may not quite understand what has happened. To make it clearer, I've created a new kind of sheet,ErrorCellSheet
, with its own guide to explain where they've come to, and how to get out. And in that sheet, the column name will becell_error
, which is more specific than the currenttext
.What do you think?