[vdsql] replace execute_iter for clickhouse/ibis 6 compatibility #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibis 6 moved away from the clickhouse-driver project in favor of clickhouse-connect. The latter client does not provide an `execute_iter` method, though it _does_ provide a row-based stream which seems to address the same general use case.
ajkerrigan
commented
Jul 20, 2023
| prog.total = con.con.last_query.progress.total_rows | ||
| prog.made = con.con.last_query.progress.rows | ||
| with con.con.query_rows_stream(sqlstr, settings) as stream: | ||
| prog.total = int(stream.source.summary['total_rows_to_read']) |
There was a problem hiding this comment.
For context, if I look at stream.source.summary when we enter this block after opening the benchmark_results table it looks like this:
{
"read_rows": "16384",
"read_bytes": "360448",
"written_rows": "0",
"written_bytes": "0",
"total_rows_to_read": "500",
"result_rows": "0",
"result_bytes": "0",
"query_id": "c413bc6a-5bd7-40a5-81bc-a64ef53dc9c8"
}
|
Thanks so much for looking into this @ajkerrigan! And to @cpcloud for explaining the problem. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibis 6 moved away from the clickhouse-driver project in favor of clickhouse-connect. The latter client does not provide an
execute_itermethod, though it does provide a row-based stream method which seems to address the same general use case.I wouldn't say I'm confident this is the right solution to #1953 - it still may need some fine-tuning but it sounds like a reasonable start. More productive than a shrug at least 😆 . Thanks to @cpcloud for providing helpful context around the underlying ibis changes.