Skip to content

Commit

Permalink
[shell] ensure add-col shell is properly quoted #2415
Browse files Browse the repository at this point in the history
Thanks @frosencrantz for suggestion of fix.
  • Loading branch information
anjakefala committed Jun 3, 2024
1 parent 738bb8b commit 3e7ded5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions dev/checklists/manual-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,4 @@
23. That DirSheet requires a commit-sheet before changes on filesystem
24. Test adding multiple aggregators via palette (+)
25. time vd -p tests/quit-nosave.vdj - note down the time. compare to PR #2369
26. Use the z; command. Then type in a command line like echo "| Ceci n'est pas une pipe"
2 changes: 1 addition & 1 deletion visidata/shell.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def calcValue(self, row):
else:
args.append(arg)

p = subprocess.Popen([os.getenv('SHELL', 'bash'), '-c', ' '.join(args)],
p = subprocess.Popen([os.getenv('SHELL', 'bash'), '-c', shlex.join(args)],
stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
return p.communicate()
except Exception as e:
Expand Down

0 comments on commit 3e7ded5

Please sign in to comment.