Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip child onClick #142

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix tooltip child onClick #142

merged 1 commit into from
Aug 12, 2024

Conversation

yuyi-sl
Copy link
Contributor

@yuyi-sl yuyi-sl commented Aug 12, 2024

Description

The tooltip prevents some event bubbling to its parents, thus blocking events set on the parent when clicking on any child components.
Quick fix: Pass the onClick event directly to the child component.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor/improvements

@yuyi-sl yuyi-sl merged commit 10232b3 into main Aug 12, 2024
2 checks passed
@yuyi-sl yuyi-sl deleted the fix-tooltip-onclick branch August 12, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant