feat(satori): drop legacy encoder.guildId #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 1 1
Lines 503 503
Branches 111 111
=======================================
Hits 433 433
Misses 70 70 ☔ View full report in Codecov by Sentry. |
ilharp
reviewed
Dec 30, 2023
Comment on lines
-343
to
+344
| `<t:${Math.ceil(quote.timestamp / 1000)}:R> [[ ↑ ]](https://discord.com/channels/${this.guildId}/${channelId}/${replyId})`, | ||
| `<t:${Math.ceil(quote.timestamp / 1000)}:R> [[ ↑ ]](https://discord.com/channels/${guildId}/${channelId}/${replyId})`, |
There was a problem hiding this comment.
这里需要同时有 guildId 和 channelId 才行吗？
There was a problem hiding this comment.
那这里大概可以单独给 quote 加个属性，用来填充或覆盖 guildId 和 channelId？直接调用 sendMessage 的时候没有接收的 session
shigma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements and supersedes #196.
Affected adapters:
cc @ilharp @XxLittleCxX