Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qq): support passive element #194

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

ilharp
Copy link
Contributor

@ilharp ilharp commented Dec 8, 2023

为 QQ 适配器引入 passive 元素,属于元信息元素,定义如下:

被动消息 (passive)

属性 类型 范围 描述
id string 关联的消息
seq number? 消息的序号,同 id 同 seq 的被动消息只会被发送一次

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f951d4b) 86.08% compared to head (bb0f8bd) 86.08%.
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files           1        1           
  Lines         503      503           
  Branches      111      111           
=======================================
  Hits          433      433           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilharp ilharp marked this pull request as ready for review December 20, 2023 12:56
Copy link
Contributor

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shigma
Copy link
Contributor

shigma commented Dec 20, 2023

cc @XxLittleCxX

@XxLittleCxX
Copy link
Member

有没有必要在 flush 的最后清空 passive 的状态

@ilharp
Copy link
Contributor Author

ilharp commented Dec 21, 2023

这个可以有

@ilharp
Copy link
Contributor Author

ilharp commented Dec 21, 2023

e5777cc

This reverts commit e5777cc.

如果拆分消息,那么每条消息都应该附带 passive。不应该去掉。
@shigma shigma merged commit acd5acf into satorijs:master Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants