Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add br and p element support and fix p behavior #152

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

Seidko
Copy link
Contributor

@Seidko Seidko commented Sep 1, 2023

Add br element support for:

  • All adapter

Add br and p element support for:

  • lark
  • line
  • qqguild

Fix p behavior

Now behavior

Check for previous \n. If no, then append \n.

Previous behavior

No check for previous \n, append \n immediately.

For following these adapter:

  • dingtalk
  • kook
  • matrix
  • slack
  • telegram
  • wechat-offical
  • wecom
  • whatsapp

close koishijs/koishi#1185

support for `discord`, `mail` and `onebot`
support for `dingtalk`, `kook`, `matrix`, `slack`, `telegram`, `wechat-offical`, `wecom` and `whatsapp`
support for `lark`, `line` and `qqguild`
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #152 (ece0ec2) into master (3f77d10) will decrease coverage by 0.07%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   81.83%   81.77%   -0.07%     
==========================================
  Files           1        1              
  Lines         424      439      +15     
  Branches       86       90       +4     
==========================================
+ Hits          347      359      +12     
- Misses         77       80       +3     

see 1 file with indirect coverage changes

Copy link
Contributor

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shigma shigma changed the title feat & fix: add br and p element support and fix p behavior feat: add br and p element support and fix p behavior Sep 8, 2023
@shigma shigma merged commit a459c48 into satorijs:master Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add br element support
3 participants