Replace Twitter to X #407
Merged
Replace Twitter to X #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the old twitter icon and share link to X
|
I've done the same on my website, but maybe it could be nice to add X as an alternative:
|
satnaing
approved these changes
Nov 5, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the
old twittericon and share link toXDescription
As the twitter was changed to
X, I guess we could replace it!Types of changes
It won't crash the page, But who uses twitter, it wont appear ... he needs to switch to
XIs it considered a Break change?
Checklist
Further comments
it will be like this