You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A SMM error popup is a bit much for something that will happen for every disabled mod in a profile. I checked the old (SMM v2) implementation for this (https://github.com/satisfactorymodding/SatisfactoryModManager/blob/v2.9.3/src/renderer/components/menu-bar/SettingsMenu.vue#L757), and it was listing all installed mods (iterating the lockfileMods list instead of the manifestMods list), in which case all mod references would be valid lockfileMods keys. Listing all mods which are in use rather than the mods in the profile also makes more sense given the original debugging purpose of copying the mods list.
@mircearoata I think the SMM error popup resulted from a miscommunication on my part, I'll fix it. I meant "I want to make sure that any errors during the copy mod process get caught as SMM errors" because the reason it took us so long to track this down is because the real error was silently eaten
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of error when trying to copy a disabled mod
rhit-silkaijr
moved this from 🏗 In progress
to 👀 Ready for Ficsit Team review
in Rose Senior Project
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Completed
in Rose Senior Project
No description provided.