Add 'Reset to Defaults' button for mod configs #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-skabelund
commented
May 20, 2025
ryan-skabelund
commented
- Added a 'Reset to Defaults' button to each mod's config page
- Added a reset to default function to each ConfigProperty (C++)
- Properties requiring a world reload when in-game do not reset
- Fixed text flicker issue in textbox widgets during construction (notably when resetting, values appeared left-aligned briefly before centering).
- Adjusted section widget spacing slightly for more consistent layout
- Converted indentation to tabs for consistency
github-project-automation
bot
moved this to 🆕 New
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
ryan-skabelund
force-pushed
the
add-reset-config-button
branch
from
32df098 to
31818a1
Compare
budak7273
moved this from 🆕 New
to 👀 In review
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
budak7273
moved this from 👀 In review
to 🏗 In progress
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
ryan-skabelund
force-pushed
the
add-reset-config-button
branch
2 times, most recently
from
6745cd6 to
d4be777
Compare
budak7273
moved this from 🏗 In progress
to 👀 In review
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
ryan-skabelund
force-pushed
the
add-reset-config-button
branch
from
d4be777 to
66f297b
Compare
- Added a 'Reset to Defaults' button to each mod's config page - Added a reset to default function to each ConfigProperty (C++) - Properties requiring a world reload when in-game do not reset - Fixed text flicker issue in textbox widgets during construction (notably when resetting, values appeared left-aligned briefly before centering). - Adjusted section widget spacing slightly for more consistent layout
- Returns a bool from every ResetToDefault() to signal success or failure - Simplified ResetToDefault() so it no longer requires a default property argument - Added an Allow User Reset toggle on each config property - Added IsSetToDefaultValue() and GetDefaultValueAsString() in UConfigProperty - Added per-option reset buttons with tooltips showing default values and why reset is disabled if it is - Moved the Reset to Defaults button to the bottom right corner to match the game options button - Added confirmation popups. Shift+click skips confirmation
- Mod reset button now disables and shows a tooltip if all settings are set to their defaults. - Updated to latest dev commit
ryan-skabelund
force-pushed
the
add-reset-config-button
branch
from
4f9e477 to
b7af332
Compare
…Reset as Transient
…tips. Change display name of ArrayProperty `DefaultValue` to `New Value Template`
…as it been showing all this time?!)
ryan-skabelund
force-pushed
the
add-reset-config-button
branch
from
eae368c to
601b096
Compare
…element as a demo of the tooltip showing it
This fixes integer enums not resetting properly and also aligns better with the overall design flow
…enabled. Hide default value when option is set to the default value. Expand array widget if collapsed on add/remove element.
- Clarified disabled mod/section tooltip when options require a world reload while in-game - Added array expansion on mod/section reset - Added section expansion on mod/section reset - Replaced 'Custom Construct' with 'Update Value' for mod/section resets
mircearoata
requested changes
Aug 22, 2025
There was a problem hiding this comment.
- Copying the Value to DefaultValue on load feels like the wrong way around to do it. It would make more sense for Value to be transient and DefaultValue to be the one set in the editor. The data would have to be migrated to the other field in PostLoad (a core redirect wouldn't work because it would hide the Value property from BP scripts)
!bAllowUserReset || !bParentSectionAllowsUserResetandbAllowUserReset && bParentSectionAllowsUserResetare used quite often both in cpp and in BP, so it would make sense to add a BlueprintCallable FORCEINLINEAllowsResetfunction returningbAllowUserReset && bParentSectionAllowsUserReset
| } | ||
| // Set default values to inherit Allow User Reset | ||
| for (UConfigProperty* Property : DefaultValues) { | ||
| if (Property && !bAllowUserReset || !bParentSectionAllowsUserReset) { |
There was a problem hiding this comment.
Suggested change
| if (Property && !bAllowUserReset || !bParentSectionAllowsUserReset) { | |
| if (Property && (!bAllowUserReset || !bParentSectionAllowsUserReset)) { |
|
|
||
| /** If true, this property can be reset by the user from the Config Widget. */ | ||
| UPROPERTY(EditAnywhere, BlueprintReadOnly, Category = "Configuration Property") | ||
| bool bAllowUserReset; |
There was a problem hiding this comment.
This is set to true in all config property BPs, so it makes sense to just make it true here by default.
Suggested change
| bool bAllowUserReset; | |
| bool bAllowUserReset = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.