-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to RunBanksy #162
Updates to RunBanksy #162
Conversation
Hi @mojaveazure , We are trying to push some updates to Thank you! |
Hi @dcollins15, we're trying to push some changes to BANKSY so users can directly install from this repo instead of our fork - but checks are failing at installation - do you know why this is the case? thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good!
Apologies for the long delay and thanks for the updates - these changes LGTM! 🥳 Updating the pre-merge check is slowly creeping up my ToDo list but you can ignore the failures for now 🙃 Before this is ready to be merged there are just a couple of small house-keeping things to take care of:
|
Hi @dcollins15, thanks for getting back - have updated DESCRIPTION and rebased. Please let me know if there's anything else to do. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wicked! Thanks @jleechung, I'll merge this in shortly 🙌
Thank you! |
This PR implements:
Seurat:::FastRowScale
).