Improve rpcs support #318
Open
Improve rpcs support #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enomis-dev
force-pushed
the
improve_rpcs_support
branch
from
7633736 to
12832b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
+ Coverage 90.86% 90.90% +0.03%
==========================================
Files 38 38
Lines 6130 6176 +46
==========================================
+ Hits 5570 5614 +44
- Misses 560 562 +2
Continue to review full report at Codecov.
|
|
Recently, I've seen that the current approach used to get corners and footprint could lead to error in mountains regions, further tests should be done. |
enomis-dev
force-pushed
the
improve_rpcs_support
branch
from
12832b6 to
d3c2322
Compare
I added the possibility to pass the dem in the kwargs of the functions in case you want to get more precise results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #316
This pull request aims to improve methods: copy_with(), footprint(), corners(), corner(), origin(), center(), resize() for rasters provided with rpcs.