Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typescript-is to typia #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change typescript-is to typia #362

wants to merge 1 commit into from

Conversation

samchon
Copy link

@samchon samchon commented Apr 30, 2023

Unfortunately, typescript-is had stopped maintaining, and does not work since TS 4.7 update.

By the way, this package has configured typescript dependency to ^4.x.x, and dependabot is running and collecting latest versions of dependencies in everyday. Therefore, using typescript-is seems very dangerous. If you accept PR of dependabot, this package would be broken, and otherwise do not accept, no reason to keep the dependabot

In such reason, I've changed typescript-is to typia. From now on, there would not be any problem on updating typescript version, and no problem to accepting PRs of dependabot


残念ながら、typescript-isはメンテナンスが中断されており、TypeScript v4.7以降は動作しなくなりました。

一方、このパッケージはtypescriptの^ 4.x.xバージョンに対してディフェンダンシーを設定しておき、毎日dependabotが動作して最新のディフェンダンシーバージョンを収集します。 したがって、typescript-isを使い続けるのは非常に危険です。 dependabotのPRを受け取ると本パッケージが壊れることになり、受け取らないとdependabotの存在意義が消えます。

このため、typescript-isをtypeiaに修正しました。 将来的にtypescriptのバージョンを上げることも、そしてdependabotのPRを受け取るにも何の問題もないでしょう。


Anyway, thanks for keeping such wonderful repo @satackey

p.s) If you want to upgrade typescript version to 5.0, you have to abandon ttypescript and accept ts-patch instead, because the ttypescript also had stopped maintaining. If you want to update the typescript@5, please tell me, then I will send a new PR again.

Unfortunately, `typescript-is` had stopped maintaining, and does not work since TS 4.7 update. However, this package configured `typescript` dependency to `^4.x.x`, therefore it seems dangerous. In such reason, I've changed `typescript-is` to `typia` that is alive.
@ThallesP
Copy link

ThallesP commented Aug 4, 2023

@samchon this repository is not maintained, you should consider making a PR to this fork https://github.com/jpribyl/action-docker-layer-caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants