Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added note after discussion with Technical Support #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zencircle
Copy link

No description provided.

@sarahcpage
Copy link
Member

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

@zencircle
Copy link
Author

zencircle commented Jan 13, 2022

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

viya4-deployment points to viya4-orders-cli to retrieve the deployment assets, hence I added here

@sarahcpage
Copy link
Member

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

viya4-deployment points to viya4-orders-cli to retrieve the deployment assets, hence I added here

Why not put the note in the viya4-deployment project README? In this project's README you could add a note to say that this tool only works with a Viya 4 2020.+ order (and not the trial) if you want.

@zencircle
Copy link
Author

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

viya4-deployment points to viya4-orders-cli to retrieve the deployment assets, hence I added here

Why not put the note in the viya4-deployment project README? In this project's README you could add a note to say that this tool only works with a Viya 4 2020.+ order (and not the trial) if you want.

Downloading assets is not part of viya-deployment package its part of viya4-orders-cli, I will create issue on viya4-deployment repo and get thoughts for the developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants