fix: (IAC-1321) updates to create NSG in network rg #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
approved these changes
Feb 14, 2024
dhoucgitter
approved these changes
Feb 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
All network related resources should get created into a vnet resource group if supplied by user. VNET gets created correctly in network resource group if
vnet_resource_group_nameis provided however, NSG creation was not following the same pattern. This PR corrects that behavior to follow the same logic.If
vnet_resource_group_nameis provided withoutnsg_name, IAC will create NSG for you in the provided vnet resource group else NSG will created in the AKS resource group like before.Tests:
Verified following scenarios, see test details in internal ticket:
vnet_resource_group_name = "rp-vnet-rg-t02"