-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: EKS Node Pool Subnets to use Single AZ by Default #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
changed the title
feat!: EKS Node Pool Subnets to use Single AZ by Default
feat!: EKS Node Group Subnets to use Single AZ by Default
Sep 26, 2023
jarpat
changed the title
feat!: EKS Node Group Subnets to use Single AZ by Default
feat!: EKS Node Pool Subnets to use Single AZ by Default
Sep 26, 2023
TestsTests move to comment for better formatting
|
jarpat
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Sep 26, 2023
thpang
reviewed
Sep 26, 2023
thpang
approved these changes
Sep 26, 2023
riragh
approved these changes
Sep 26, 2023
dhoucgitter
reviewed
Sep 27, 2023
dhoucgitter
approved these changes
Sep 27, 2023
dhoucgitter
reviewed
Sep 27, 2023
dhoucgitter
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In order to line up with the recommendations from the SAS Viya Platform Operations documentation we are updating the code base so that when EKS node groups are created they will be placed in a single-AZ rather than spanning over multiple-AZs. This feature is controlled by the new variable
enable_multi_zone
which by default will be set to false, resulting in the node groups being a single subnet in a single-az.This is considered a breaking change single since users who initially created their infrastructure with viya4-iac-aws:7.2.1 or earlier, and want to use the new version to make adjustments to their infrastructure will now have their node groups moved to a single-az. If they have a stopped Viya deployment they were planning on starting after the infrastructure updates, they will most likely run in SAS Viya pod instability as they try to get it back online. Our recommendation for those users is to set
enable_multi_zone
to true when they runapply
again to keep their node groups in a multi-az configuration so that the Viya pods are unaffected. Alternatively if the user wants to move over to a single-az configuration from their previous multi-az deployment following the SAS Viya Platform Operation backup and restore documentation is recommended.Relevant SAS Viya Platform documentation for AWS Cluster Requirements:
https://documentation.sas.com/?cdcId=itopscdc&cdcVersion=default&docsetId=itopssr&docsetTarget=n098rczq46ffjfn1xbgfzahytnmx.htm#p0vx68bmb3fs88n12d73wwxpsnhu
Tests
Put tests in comment for better formatting:
#234 (comment)