Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create NIST_FEATURES_ENABLED flag for NIST effort #566

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

dhoucgitter
Copy link
Member

Create a NIST_FEATURES_ENABLED feature flag for the DAC project, similar to what has already been created in the IAC AWS project.

@dhoucgitter dhoucgitter added the enhancement New feature or request label Aug 2, 2024
@dhoucgitter dhoucgitter self-assigned this Aug 2, 2024
@dhoucgitter dhoucgitter requested a review from illianov August 2, 2024 19:02
@dhoucgitter dhoucgitter marked this pull request as draft August 2, 2024 19:02
Copy link

@illianov illianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that I see some linting errors for missing newline characters in the main.yaml's?

@illianov
Copy link

illianov commented Aug 5, 2024

I thought I saw some missing newline errors but I also see that all checks have passed.

@illianov
Copy link

illianov commented Aug 5, 2024

Oh nevermind, I see your commit to fix those.

@dhoucgitter dhoucgitter requested review from saschjmil and jarpat August 5, 2024 18:47
@dhoucgitter
Copy link
Member Author

For reviewers, these changes will be pushed to the main branch without cutting a new release.

@dhoucgitter dhoucgitter marked this pull request as ready for review August 7, 2024 17:15
@dhoucgitter dhoucgitter changed the base branch from staging to main August 7, 2024 17:16
@dhoucgitter dhoucgitter merged commit b546324 into main Aug 7, 2024
3 checks passed
@dhoucgitter dhoucgitter deleted the PSKD-559 branch August 7, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants