fix: (PSKD-398) Update v4m storage class deletion behavior #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
changed the title
jarpat
commented
Jul 1, 2024
| @@ -50,15 +50,40 @@ | |||
| tags: | |||
| - cluster-logging | |||
|
|
|||
| - name: V4M - check if storage class is being used | |||
| ansible.builtin.shell: | | |||
There was a problem hiding this comment.
Just a note, used shell here rather than the ansible kubernetes.core.k8s_info module since PVs are not filterable using field selectors. This was the cleanest way to search if any PVs using a particular SC that I found.
Field Selector Support: https://kubernetes.io/docs/concepts/overview/working-with-objects/field-selectors/#list-of-supported-fields
thpang
approved these changes
Jul 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated the uninstallation behavior when
V4_CFG_MANAGE_STORAGE:true&PROVIDER in ["azure","aws","gcp"]so that the v4m storage class will not be removed if there are still PVs using it. If no PVs are making use of the v4m sc then it will also be removed. This prevents the v4m SC from being removed if a user just uninstalls only logging or only monitoring.Tests