Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (IAC-1335) Resolve: doc is missing path: "/spec/volumeClaimTemplates/0/spec/storageClassName" error #521

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Jan 29, 2024

Changes

  • Avoid applying the sas-storage.yaml patchTransformer for the sas-airflow component so that DAC can successfully build the deployment manifest without encountering the fatal error indicated in the subject.
  • Pin urllib3 to latest 1.26.x version. Use of urllib3>= 2.1.0 leads to the following error getting the orchestration tooling image when running DAC with a locally installed Ansible binary.

TASK [vdm : Orchestration tooling - orchestration tooling image] ***************
task path: ~/gitlab.sas.com/DOPE/ansible-marketplace/viya4-deployment/public/roles/orchestration-common/tasks/orchestration_tooling.yaml:153
fatal: [localhost]: FAILED! => changed=false
msg: 'Error connecting: Error while fetching server API version: HTTPConnection.request() got an unexpected keyword argument ''chunked'''

Tests

Provider K8s Deploy method Order Notes
AWS 1.27 ansible, installed in Python virtual env includes SAS airflow component DAC "baseline, viya, install" with DEPLOY=false runs to completion without error; kustomize build . -o site.yaml command to build manifest in the deployment folder is successful
AWS 1.27 ansible, installed in Python virtual env includes SAS airflow component DAC "baseline, viya, install" with DEPLOY=true runs to completion without error; sas-airflow requires additional configuration and is expected

@dhoucgitter dhoucgitter added the bug Something isn't working label Jan 29, 2024
@dhoucgitter dhoucgitter self-assigned this Jan 29, 2024
@dhoucgitter dhoucgitter marked this pull request as draft January 29, 2024 23:35
@dhoucgitter dhoucgitter marked this pull request as ready for review January 30, 2024 15:37
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhoucgitter dhoucgitter merged commit a5220c6 into staging Jan 30, 2024
3 checks passed
@dhoucgitter dhoucgitter deleted the fix/iac-1335 branch January 30, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants